Fastest Way to Read Process Memory C#

We strive to provide all our services for gratis and non interrupt your visit with intrusive advertisements or restrictions - support us past disabling your ad blocker or whitelisting our site.

Become to Page...

UnKnoWnCheaTs - Multiplayer Game Hacking and Cheats Anti-Cheat Software & Programming General Programming and Reversing [Information] Proper ReadProcessMemory Usage

Salve Authenticator Lawmaking

Thread Tools

Proper ReadProcessMemory Usage

13th June 2018, 08:28 AM	#1
coltonon reinterpret_cast<motorcar> Join Date: Jun 2016 Location: Anti-Anime Rally Posts: 1,286 Reputation: 55579 Rep Power: 207 Recognitions Donator (13) Former Staff Member of the Month (i) Gratuity (one) Points: 92,785, Level: 44 Level up: 33%, 2,515 Points needed Activity: i.v% Terminal Achievements	Proper ReadProcessMemory Usage I see this way too often, people using ReadProcessMemory wrong. People get used to bad C# methods, and never fix their inefficient ways. Apologies for the depression sound. The thought is, since you've already spent all that time in reclass, and yous're certainly non pasting, you might too utilize the internal-intended lawmaking generation tool. Simply alter every pointer to a DWORD_PTR, and read it with ReadProcessMemory. C++: template <class C> C read(DWORD_PTR(Address)) { C c; ReadProcessMemory(hProcess, reinterpret_cast<LPCVOID>(Address), &c, sizeof(c), nullptr); render c; } Don't go using some stupid-ass class for readprocessmemory in C++, this is the most fancy matter you'll need. BTW, I came up with this for reading Char*'s C++: #pragma warning(disable:4996) std::wstring readpChar(DWORD64 accost) { endeavour { if (address != 0) { const size_t namesize = 500; char x[namesize]; ReadProcessMemory(this->hProcess, reinterpret_cast<LPCVOID>(address), &ten, namesize, nullptr); std::wstring tmpname = std::wstring(&x[0], &10[namesize]); wchar_t* czech = wcstok(&tmpname[0], L"\0"); if (czech != nullptr) return czech; } } catch (const std::exception &exc) {} render std::wstring(L"\0"); } It'd be squeamish to have something tho that doesn't crave you to disable a warning Concluding edited by coltonon; 13th June 2022 at 08:47 AM.
coltonon is offline

13th June 2018, 09:52 AM	#2
krystalgamer 01000101 Join Appointment: Apr 2015 Location: 0xDEADBEEF Posts: 789 Reputation: 12114 Rep Ability: 187 Points: 22,475, Level: 21 Level up: 5%, i,525 Points needed Activity: 2.iv% Concluding Achievements	Tbh, not really a fan of your method of reading char*. At that place's some cases where what you might exist reading is actually \0. I've washed real quick. Basically information technology returns the number of characters read. If the string has more than 1024 characters it will perform twice the RPM(might be faster than realloc'ng). Those c++ constructs don't actually help, imo they make code harder to read. C++: uint32 readpChar(DWORD64 accost, char **res){ static char buffer[1024]; if(!address) return 0; bool hasRead = false; uint32 totalBytes = 0; while(!hasRead){ RPM(process, address+totalBytes, buffer, 1024, nullptr); for(uint32 i = 0; i<1024; i++){ if(!isPrintableChar(buffer[i])) interruption; totalBytes++; } } if(!totalBytes) render 0; *res = malloc(totalBytes); if(!res) return 0; uint32 bytesToWrite = totalBytes; if(bytesToWrite <= 1024){ memcpy(*res, buffer, bytesToWrite); return totalBytes; } while(bytesToWrite){ uint32 write = (bytesToWrite >= 1024) ? 1024 : 1024 - bytesToWrite; RPM(process, address+totalBytes-bytesToWrite, buffer, write, nullptr); memcpy(*res, buffer, write); bytesToWrite -= write; } return totalBytes; } EDIT: Just noticed the last loop can be optimized to 2N-1 RPMs, by writting from the end to the start. __________________
krystalgamer is offline

13th June 2018, 10:37 AM	#3
MagicM8 Hacker Supreme Join Date: Jun 2016 Posts: 240 Reputation: 26819 Rep Power: 168 Recognitions Member of the Month (two) Competition Winner (ane) Points: 30,601, Level: 26 Level up: vi%, 1,599 Points needed Activity: ii.iv% Final Achievements	No just no. Like what the fuck. It's not that hard to read a c string isn't it? C++: template<course CharT = char> std::basic_string<CharT> read_chars(std::uintptr_t address, std::size_t max_length = 256) { std::basic_string<Nautical chart> str(max_length, Chart()); // I'll assume this throws on failed read. // If y'all are using c++17 you lot can call str.information() instead of &str[0] read(accost, &str[0], sizeof(CharT) * max_length); // get the position of zero terminator auto information technology = str.notice(CharT()); // don't want to waste an allocation and volition render the existing cord to be reused if(information technology == str.npos) str.articulate(); else str.resize(it); return str; } Quote: Originally Posted by krystalgamer Those c++ constructs don't really help, imo they make code harder to read. Coltonons code wasn't the all-time only at least was readable and didn't actually take whatsoever bugs. On the other mitt you literally turned a few lines of simple code to a buggy mess. Your first loop alone is already cleaved. Y'all don't check what rpm returns and have a possibly space loop because of that. The buffer is as well static which means you can't use this with multiple threads. Next yous dereference res and use fucking malloc. And then y'all check if res is not null which will get optimized out because the beginning dereference would cause crash otherwise so continue to non check if malloc returned null. Actually thought that this is just some bad C code until I noticed the nullptr.
MagicM8 is offline

13th June 2018, 10:54 AM	#4
krystalgamer 01000101 Bring together Date: Apr 2015 Location: 0xDEADBEEF Posts: 789 Reputation: 12114 Rep Power: 187 Points: 22,475, Level: 21 Level up: 5%, 1,525 Points needed Activity: ii.iv% Final Achievements	Quote: Originally Posted by MagicM8 On the other hand you literally turned a few lines of simple code to a buggy mess. Weird, unremarkably when I write code in notepad and don't even compile it is perfect. Quote: Originally Posted by MagicM8 Your starting time loop solitary is already broken. You lot don't check what rpm returns and have a maybe space loop because of that. Geez, I guess forgot to write a quick cheque on a 5 minute snippet. Quote: Originally Posted by MagicM8 The buffer is besides static which means you can't use this with multiple threads. Y'all're right. Didn't had that in mind. Usually write my externals has a big read and then process data. Quote: Originally Posted past MagicM8 Side by side you dereference res and use fucking malloc. And so y'all check if res is not cipher which will get optimized out considering the first dereference would cause crash otherwise and then keep to not check if malloc returned null. Note that res is arrow to a pointer? Also you're correct in checking res, information technology should've been if(!*res). Quote: Originally Posted by MagicM8 Really thought that this is only some bad C code until I noticed the nullptr. It is C code, just wrote nullptr, due to being lazy. __________________
krystalgamer is offline

13th June 2018, 12:24 PM	#v
MagicM8 Hacker Supreme Bring together Engagement: Jun 2016 Posts: 240 Reputation: 26819 Rep Power: 168 Recognitions Fellow member of the Month (two) Contest Winner (1) Points: 30,601, Level: 26 Level upwards: 6%, one,599 Points needed Activity: ii.4% Final Achievements	Quote: Originally Posted by krystalgamer Weird, usually when I write code in notepad and don't fifty-fifty compile it is perfect. I wrote my code in the UC reply box, does that arrive fine for it to be broken? You likewise missed the whole bespeak. The code that contonon and I wrote are around x lines of unproblematic C++ that are easy to read and whose logic is extremely simple. Your code is 30 lines of C with a much more than complicated logic that you cannot empathize at a glance and a lot of mistake handling that you tin can miss.
MagicM8 is offline

13th June 2018, 04:53 PM	#6
krystalgamer 01000101 Bring together Date: April 2015 Location: 0xDEADBEEF Posts: 789 Reputation: 12114 Rep Power: 187 Points: 22,475, Level: 21 Level upwards: 5%, i,525 Points needed Activity: 2.4% Last Achievements	Quote: Originally Posted by MagicM8 I wrote my code in the UC answer box, does that make information technology fine for it to be broken? Yes, it does. Quote: Originally Posted by MagicM8 You also missed the whole point. The lawmaking that contonon and I wrote are effectually 10 lines of simple C++ that are easy to read and whose logic is extremely simple (...) Your code is 30 lines of C I don't know why you're and then mad. The and so called "master signal" is just a line, the residual of your postal service was nitpicking a poorly written C snippet. Y'all missed that res is a pointer of a pointer, and so that whole talk about crash and malloc doesn't make sense. What i discover more amusing is that your code has the same RPM/read flaw every bit mine. Quote: Originally Posted by MagicM8 with a much more complicated logic that you cannot empathise at a glance Much more complicated? Reading an array of chars and neither of you lot check if you're reading valid characters(+2 if statement and while loop) Both of you are limited to a number of characters to read, mine allows as many as the memory can handle(+ane while statement) Since I'm using C i'1000 using malloc, but new would've sufficed too(+ane null bank check, which is trivial when working with C) If the local buffer tin't concur all the characters then information technology goes on a loop(+ii, if statement and while loop). Existence this said it's normal I take more lines. Quote: Originally Posted by MagicM8 a lot of error treatment that you lot tin miss. Oh, please tell me more. __________________
krystalgamer is offline

13th June 2018, 09:33 PM	#7
MagicM8 Hacker Supreme Join Date: Jun 2016 Posts: 240 Reputation: 26819 Rep Power: 168 Recognitions Fellow member of the Month (2) Contest Winner (1) Points: 30,601, Level: 26 Level up: vi%, 1,599 Points needed Activeness: ii.iv% Last Achievements	Quote: Originally Posted by krystalgamer I don't know why you're and so mad. Mad would be the wrong word. Disappointed would fit better. Quote: Originally Posted by krystalgamer Y'all missed that res is a pointer of a pointer, so that whole talk well-nigh crash and malloc doesn't brand sense. It doesn't make sense to me how you managed to come to such a conclusion either. Quote: Originally Posted by krystalgamer What i find more amusing is that your code has the same RPM/read flaw as mine. What flaw? No error checking? Annotate above notes that I presume the read throws on failure. Quote: Originally Posted by krystalgamer Much more complicated? 11 command flow statements (if we add together all the missing mistake handling) versus 1/2 (depends on whether you lot count the else which you lot can get rid of easily). I'd say a difference by a whole order of magnitude can exist called "much more". Quote: Originally Posted by krystalgamer Reading an array of chars and neither of yous check if you're reading valid characters (+2 if statement and while loop) If your lawmaking reads reads unprintable garbage you already have a problem somewhere. It also isn't +2 if statements and a while loop. C++: template<class CharT = char> std::basic_string<CharT> read_chars(std::uintptr_t address, std::size_t max_length = 256) { std::basic_string<Chart> str(max_length, Chart()); read(address, &str[0], sizeof(CharT) * max_length); auto it = str.notice(CharT()); // the only changed line. As y'all tin can see no while loop or ii ifs if(it == str.npos || !std::all_of(str.begin(), str.begin() + it, isprint)) str.articulate(); else str.resize(information technology); render str; } Quote: Originally Posted by krystalgamer Both of you are limited to a number of characters to read, mine allows equally many as the retentivity can handle ... Sure. Would demand a few while loops as well, however the c++ code would still be more than expressive and a bit shorter. Quote: Originally Posted past krystalgamer Oh, please tell me more than. Non sure what practice you expect me to reply with. Your "quick 5 minute code" has 3 error checks missing?
MagicM8 is offline

13th June 2018, x:53 PM	#8
krystalgamer 01000101 Join Appointment: Apr 2015 Location: 0xDEADBEEF Posts: 789 Reputation: 12114 Rep Ability: 187 Points: 22,475, Level: 21 Level upwardly: 5%, 1,525 Points needed Activity: 2.4% Last Achievements	Quote: Originally Posted by MagicM8 Mad would be the wrong give-and-take. Disappointed would fit better. Geez, dad. I promise I won't go benched anymore. Quote: Originally Posted by MagicM8 It doesn't make sense to me how yous managed to come to such a conclusion either. "Adjacent you dereference res and use fucking malloc." <- I'm dereferencing a pointer to a arrow and at that place's nothing wrong with malloc. "the first dereference would cause crash" <- no it wouldn't, res is non cipher. Quote: Originally Posted by MagicM8 Comment higher up notes that I assume the read throws on failure. Then what? RPM could've as well been a macro. That comment was but retarded. Quote: Originally Posted by MagicM8 11 control flow statements (if we add all the missing error treatment) versus 1/2 (depends on whether you count the else which you can become rid of hands). I'd say a difference by a whole order of magnitude tin be called "much more". I don't know if you realized but that'due south C not C++. Deplorable for non using the large bois C++ data types. Quote: Originally Posted by MagicM8 If your code reads reads unprintable garbage you already take a problem somewhere. It also isn't +2 if statements and a while loop. So you want to read a char assortment from memory but know the length earlier paw? Mine doesn't know the length and calculates information technology, is it actually hard to understand? Coltonon's code does the aforementioned but with find(). Quote: Originally Posted by MagicM8 ~ insert large boi code ~ wow, amazing. Quote: Originally Posted by MagicM8 Certain. Would demand a few while loops too, all the same the c++ code would nonetheless be more expressive and a bit shorter. Pssst, here's a underground. Mine is C not C++. "But you used nullptr... Bwaaaaaaaaa", sorry dad for letting it slip. Y'all're reading a char array so I render one, I dislike the version with C++ strings, deal with information technology. Not forcing information technology on anyone, just provided an alternative. Quote: Originally Posted by MagicM8 Not certain what do you expect me to reply with. Your "quick v infinitesimal code" has 3 error checks missing? Oh, no! A slice of code meant to be taken equally an idea just to share my point of view on the thing has errors?! Being this said I'll end this pissing contest right here. __________________
krystalgamer is offline

13th June 2018, xi:00 PM	#9
wlan forum administrator Join Date: May 2013 Posts: 3,431 Recognitions File Analyzer Points: 176,599, Level: 59 Level up: 2%, 317,401 Points needed Action: 2.5% Last Achievements	can y'all calm down with the proper name calling please. it's non helping.
wlan is offline

14th June 2018, 10:18 AM	#10
MagicM8 Hacker Supreme Join Engagement: Jun 2016 Posts: 240 Reputation: 26819 Rep Ability: 168 Recognitions Member of the Month (2) Contest Winner (1) Points: 30,601, Level: 26 Level upwardly: vi%, one,599 Points needed Activeness: 2.4% Last Achievements	Quote: Originally Posted by krystalgamer Beingness this said I'll terminate this pissing contest right hither. If that's that for you, nosotros tin can end this. However I will first come back to the pointer part that you seem to accept been unable to translate correctly for the past 3 replies. Quote: Originally Posted by krystalgamer "Next you dereference res and utilize fucking malloc." <- I'grand dereferencing a pointer to a pointer and there's nothing wrong with malloc. In first reply I was under assumption you used c++ so the "fucking malloc" office doesn't apply anymore and I'm not sure how logical would this be if it were a simple pointer to char. Casting a void* to char implicitly? Quote: Originally Posted by krystalgamer "the commencement dereference would cause crash" <- no it wouldn't, res is not cypher. That's a really nice example of taking words out of context. Lets look at the actual judgement. Quote: Originally Posted by MagicM8 And then you bank check if res is non null which will become optimized out because the first dereference would crusade crash otherwise then continue to non check if malloc returned null. Let me rephrase this more clearly so y'all can sympathize: if res is zero and yous dereference it yous crash. Because the check if res is null is only after the dereference it will get optimized out. The next part about not checking what malloc returned would be nonsense too if it were a simple char*.
MagicM8 is offline

15th June 2018, x:37 PM	#11
Soreeros Super l337 Join Date: Mar 2017 Posts: 200 Reputation: 1126 Rep Power: 124 Points: 4,992, Level: 7 Level upward: 55%, 408 Points needed Activity: 6.vii% Last Achievements	Have you lost your canis familiaris or something?
Soreeros is offline

16th June 2018, 04:02 AM	#12
coltonon reinterpret_cast<automobile> Threadstarter Join Engagement: Jun 2016 Location: Anti-Anime Rally Posts: 1,286 Reputation: 55579 Rep Power: 207 Recognitions Donator (13) Onetime Staff Member of the Month (i) Gratuity (1) Points: 92,785, Level: 44 Level upwardly: 33%, 2,515 Points needed Activity: i.5% Terminal Achievements	Quote: Originally Posted by Soreeros Have you lot lost your domestic dog or something? Who was that directed to..?
coltonon is offline

16th June 2018, 04:50 AM	#13
Soreeros Super l337 Join Appointment: Mar 2017 Posts: 200 Reputation: 1126 Rep Power: 124 Points: iv,992, Level: 7 Level up: 55%, 408 Points needed Activity: 6.7% Final Achievements	Quote: Originally Posted by coltonon Who was that directed to..? I don't know,maybe both of them have lost something of import in their life recently. lol shit joke aside squeamish release btw The video is easy to follow. +rep
Soreeros is offline

We strive to provide all our services for free and not interrupt your visit with intrusive advertisements or restrictions - back up usa past disabling your ad blocker or whitelisting our site.

Similar Threads
Thread	Thread Starter	Forum	Replies	Final Post
[Question] Pointer usage	deve	C and C++	22	20th Nov 2011 07:50 PM
[Question] Miniumum data usage	General 747	Battlefield Heroes	20	7th October 2010 05:58 AM
[Release] Best AIMBOT Unproblematic Usage	Decimated	Call of Duty six: Modern Warfare 2	2	fifth March 2010 04:00 AM
BatchFile Usage (Speed Modern, etc)	UberMOUSE	America's Army Operations 2.x	38	12th January 2005 07:05 AM
lsass.exe taking up mem usage	[n0th1ng]	PC Software	15	9th June 2004 09:27 AM

Tags

return, czech, address, stdwstring, namesize, const, nullptr;, people, stupid-donkey, class

« Previous Thread | Adjacent Thread »

Forum Leap

All times are GMT. The fourth dimension now is 09:07 AM.

Contact Us - Toggle Nighttime Theme

Terms of Use Information Privacy Policy Information
Copyright ©2000-2021, Unknowncheats� UKCS #312436

no new posts

garnergint1999.blogspot.com

Source: https://www.unknowncheats.me/forum/general-programming-and-reversing/285308-proper-readprocessmemory-usage.html